Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORY] Port Freesurfer ApplyVolTransform Nipype interface to Pydra #199

Open
1 task
Tracked by #79
tclose opened this issue Sep 30, 2022 · 1 comment
Open
1 task
Tracked by #79

[STORY] Port Freesurfer ApplyVolTransform Nipype interface to Pydra #199

tclose opened this issue Sep 30, 2022 · 1 comment
Assignees
Labels
analysis-design Complex analysis workflow epic mid-level Requires moderate framework/domain-specific knowledge pipelines story a unit of work

Comments

@tclose
Copy link
Contributor

tclose commented Sep 30, 2022

Metadata

Epic: #17
Feature: #79
Feature Release: 1

Description

As a user, I want to be able to use Pydra interfaces for selected Freesurfer commands, so I can reimplement sMRIPrep in Pydra

Acceptance Criteria

Port the following Freesurfer Nipype interfaces to Pydra with appropriate tests

  • ApplyVolTransform()

Notes

This interface should go in the https://github.com/nipype/pydra-freesurfer repository in modules named recon.py and utils.py in https://github.com/nipype/pydra-freesurfer/tree/master/pydra/tasks/freesurfer.

There is a script for porting from the Nipype interface to Pydra in the "port-converter" branch of that repository (https://github.com/nipype/pydra-freesurfer/tree/port-converter). @Mahdieh-dst should be able to help you get set up to use it

Please refer to https://github.com/nipype/pydra-dcm2niix/blob/main/pydra/tasks/dcm2niix/utils.py for the latest style to use while defining the interface and the Pydra docs: https://pydra.readthedocs.io/en/latest/input_spec.html & https://pydra.readthedocs.io/en/latest/output_spec.html for more information (although the docs are a little light)

@github-actions github-actions bot added pipelines story a unit of work labels Sep 30, 2022
@tclose tclose moved this to Todo in AIS Master Project Sep 30, 2022
@tclose tclose added analysis-design Complex analysis workflow epic mid-level Requires moderate framework/domain-specific knowledge labels Sep 30, 2022
@ablachair ablachair moved this from Todo to In Progress in AIS Master Project Oct 16, 2022
@ablachair
Copy link
Contributor

The script generates the new interface.
The doctest currently fails because the Input ported fields spec

  1. requires "target_file", "tal" and "fs_target"
  2. declares these fields mutually exclusive (xor)

We might need to override input specs manually in this issue
And create a new issue to fix the porting script accordingly

@ablachair ablachair moved this from In Progress to Code Review in AIS Master Project Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis-design Complex analysis workflow epic mid-level Requires moderate framework/domain-specific knowledge pipelines story a unit of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants