-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engineering lobby revision #19996
Merged
NonQueueingMatt
merged 6 commits into
Aurorastation:master
from
FabianK3:engineering-lobby-revision
Oct 14, 2024
Merged
Engineering lobby revision #19996
NonQueueingMatt
merged 6 commits into
Aurorastation:master
from
FabianK3:engineering-lobby-revision
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New layout - Add notice board - Moved engineering FAK locker
github-actions
bot
added
the
🗺️ Mapping - Horizon
The PR touches the Horizon map files.
label
Oct 4, 2024
!review |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
courierbravo
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Doors, buttons, etc all appear to be set correctly, along with relevant markers.
FluffyGhoster
approved these changes
Oct 13, 2024
hazelrat
approved these changes
Oct 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
This PR re-adds the engineering lobby of #19996 that has been overridden with the merge of the BSD #20053. Previous source branch has been restored. Appendum: - I'm considering the PR ready when the mapdiffbot shows no changes outside the original engineering lobby and all checks are green, as the original PR already got reviewed/merged. - Marking it as bugfix for obvious reasons/transparency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR has the focus to revise the engineering lobby layout.
This is a revision to the first PR that has been closed to address different issues. (#19945).
What changed?
Preview