Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a rattling emote for Attendants #20007

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

hazelrat
Copy link
Contributor

@hazelrat hazelrat commented Oct 6, 2024

At request of bug lore, adds a *rattle audible emote available exclusively to Vaurca Attendants.

Sound origin. As far as I know this shouldn't require attribution.

@hazelrat
Copy link
Contributor Author

hazelrat commented Oct 6, 2024

!review

Copy link
Contributor

@Geevies Geevies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having looked into Uppbeat's licensing scheme and their paid plans, plus what they deem 'Uppbeat' credits being 'one video per download', i'm not entirely convinced we'll be able to distribute it permanently via git, especially not without attributions

is it possible that the vaurca team could get the same sound from a source with better outlined licensing?

@hazelrat
Copy link
Contributor Author

hazelrat commented Oct 8, 2024

@Geevies New sound added from here, license here.

Copy link
Contributor

@DreamySkrell DreamySkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high priority need this merged ASAP

@BotBOREALIS BotBOREALIS added Waiting Period The PR has the required number of reviews, but is still in the waiting period Awaiting Merge and removed Review Required Waiting Period The PR has the required number of reviews, but is still in the waiting period labels Oct 8, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Oct 10, 2024
Merged via the queue into Aurorastation:master with commit 6968e0d Oct 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants