From 1614f9ade4ba87070c48ad0e2c84a1fe192038fc Mon Sep 17 00:00:00 2001 From: Fluffy <65877598+FluffyGhoster@users.noreply.github.com> Date: Wed, 9 Oct 2024 07:06:49 +0200 Subject: [PATCH] Fix gremorian nurses (#20022) Generic attacks below 15 damage were being ignored due to a logic error in how the shields are handled, now they aren't anymore, fixes gremorian nurses doing no damage and possibly other things. --- .../living/carbon/human/human_attackhand.dm | 2 +- .../fluffyghost-fixnursesandmore.yml | 58 +++++++++++++++++++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 html/changelogs/fluffyghost-fixnursesandmore.yml diff --git a/code/modules/mob/living/carbon/human/human_attackhand.dm b/code/modules/mob/living/carbon/human/human_attackhand.dm index c0447618a07..0d9890bd4a3 100644 --- a/code/modules/mob/living/carbon/human/human_attackhand.dm +++ b/code/modules/mob/living/carbon/human/human_attackhand.dm @@ -549,7 +549,7 @@ user.attack_log += "\[[time_stamp()]\] attacked [src.name] ([src.ckey])" src.attack_log += "\[[time_stamp()]\] was attacked by [user.name] ([user.ckey])" user.do_attack_animation(src) - if(damage < 15 && (check_shields(damage, null, user, null, "\the [user]") == BULLET_ACT_HIT)) + if(damage < 15 && (check_shields(damage, null, user, null, "\the [user]") != BULLET_ACT_HIT)) return visible_message(SPAN_DANGER("[user] has [attack_message] [src]!")) diff --git a/html/changelogs/fluffyghost-fixnursesandmore.yml b/html/changelogs/fluffyghost-fixnursesandmore.yml new file mode 100644 index 00000000000..56020b68c50 --- /dev/null +++ b/html/changelogs/fluffyghost-fixnursesandmore.yml @@ -0,0 +1,58 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# - (fixes bugs) +# wip +# - (work in progress) +# qol +# - (quality of life) +# soundadd +# - (adds a sound) +# sounddel +# - (removes a sound) +# rscadd +# - (adds a feature) +# rscdel +# - (removes a feature) +# imageadd +# - (adds an image or sprite) +# imagedel +# - (removes an image or sprite) +# spellcheck +# - (fixes spelling or grammar) +# experiment +# - (experimental change) +# balance +# - (balance changes) +# code_imp +# - (misc internal code change) +# refactor +# - (refactors code) +# config +# - (makes a change to the config files) +# admin +# - (makes changes to administrator tools) +# server +# - (miscellaneous changes to server) +################################# + +# Your name. +author: FluffyGhost + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. +# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. +changes: + - bugfix: "Generic attacks below 15 damage were being ignored due to a logic error in how the shields are handled, now they aren't anymore, fixes gremorian nurses doing no damage and possibly other things."