drivers: led: lp5569: implement write_channels api #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lp5569 controller supports auto-increment for its registers. This is by default enabled in the chip, but the driver actively disabled it. Since auto-increment is useful for writing multiple consecutive registers, enable the feature. The driver, however, doesn't perform such consecutive writes and thus the existing behavior is not altered. Signed-off-by: Emil Dahl Juhl <[email protected]> (cherry picked from commit 8a78596) Submitted for upstream in: zephyrproject-rtos#81497
The lp5569 has multiple pwm outputs, and thus implementing the write_channels api to set multiple values in a single call makes sense. Implement the write_channels function with a basic range check on the channel range. Since the lp5569 supports auto-increment, all of the channels can be written in one i2c transfer, starting from the pwm register of the start_channel. Signed-off-by: Emil Dahl Juhl <[email protected]> (cherry picked from commit e59c459) Submitted for upstream in: zephyrproject-rtos#81497
Emil-Juhl
requested review from
DmtKats,
dkarnikis,
Svendsen991 and
PedroSAndre
|
Since we are far far behind upstream main, the first commit didn't cherry-pick cleanly. But this is merely due to formatting. |
DmtKats
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.
Submitted for upstream: zephyrproject-rtos#81497