-
Notifications
You must be signed in to change notification settings - Fork 37
Support linting in Vue single-file components #406
Conversation
This looks cool. Should we add the other scopes language-vue supports? Adding |
Please add specs which test |
I think we would want to add the embedded scopes for things like css and less when doing this, not just scss. Also, there are other use cases where adding scopes would add support for certain files (i.e. react styled-components and typescript), but I don't think we want to just continuously add to the scopes definition each time this comes up. I would rather see us provide a configuration option where scopes could be added by the end user when they needed them; something similar to my comments on #235. |
@1000ch I added test for the Vue + SCSS case. I guess it would make sense to add support for other languages. I could extend this PR to handle it if somebody could give me a list of what else to add. |
d327750
to
4b64b4e
Compare
Would be great to see this one get merged in. |
What's missing for this to be merged ? |
This comment has been minimized.
This comment has been minimized.
@Arcanemagus Can we get this merged in? I don't think I can add the other languages suggested in the thread (LESS and CSS in Vue SFC), but I think this is a good start that somebody else can copy. |
7e5ad9a
to
f269c79
Compare
I forked a linter-stylelint-plus package that supports custom scopes and stylelint configOverrides. https://atom.io/packages/linter-stylelint-plus |
The linter is breaking Fuzzy Finder when we add to scope macOS 11.1 Big Sur Atom packages Fuzzy Finder had this related issues: I tried deactivating Is there anyone else with this problem? |
This adds the
source.css.scss.embedded.html
scope (used for style tags in vue single page components) in order to enable stylelint linting in.vue
files.Fixes #403