Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test identifier functions #6

Open
daxkellie opened this issue Dec 20, 2024 · 0 comments
Open

Test identifier functions #6

daxkellie opened this issue Dec 20, 2024 · 0 comments
Labels
enhancement New feature or request tests Adding or fixing tests

Comments

@daxkellie
Copy link
Collaborator

The group of functions random_id(), sequential_id() and composite_id() need to be tested for robustness. These functions can auto-build unique identifiers for users, and importantly, they shouldn't be allowed to be overwritten once they exist in a dataset (otherwise, they are no longer useful identifiers).

It might be worth checking whether they work as expected, and ensure that the messages returned in the console are nice and clear about what they are doing. It also would be good to return errors when they are used within columns or functions they aren't meant for (e.g., use_coordinates() and the supported spatial columns).

@daxkellie daxkellie added enhancement New feature or request tests Adding or fixing tests labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Adding or fixing tests
Projects
None yet
Development

No branches or pull requests

1 participant