You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is inconsistent CSV escape/quoting in files created by ExportFromIndexStream. Some files created by it require manually setting the non-RFC4180 escape character to \ while other require it to explicitly not set, or line size errors are artificially created. Reviewing the code, there are some calls to one constructor for CSVWriter that specifies the \ explicitly, indicating it was intentionally chosen by a biocache-store committer. However, others use the other constructor where those arguments are implicitly set, which in at least some opencsv versions is the RFC4180 quote character ".
A simple solution to this issue would be to switch all CSV writing and parsing to RFC4180, with no escape character, and just relying on the quote character.
There is inconsistent CSV escape/quoting in files created by ExportFromIndexStream. Some files created by it require manually setting the non-RFC4180 escape character to
\
while other require it to explicitly not set, or line size errors are artificially created. Reviewing the code, there are some calls to one constructor for CSVWriter that specifies the\
explicitly, indicating it was intentionally chosen by a biocache-store committer. However, others use the other constructor where those arguments are implicitly set, which in at least some opencsv versions is the RFC4180 quote character"
.A simple solution to this issue would be to switch all CSV writing and parsing to RFC4180, with no escape character, and just relying on the quote character.
Some background on the historical inconsistencies that are kept inside of OpenCSV for "backwards-compatibility" reasons at https://sourceforge.net/p/opencsv/support-requests/50/
The text was updated successfully, but these errors were encountered: