Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hex bin option to WMS #880

Open
adam-collins opened this issue Feb 8, 2024 · 4 comments
Open

Add hex bin option to WMS #880

adam-collins opened this issue Feb 8, 2024 · 4 comments
Assignees
Milestone

Comments

@adam-collins
Copy link
Contributor

Hex bins will operate the same as grid bins, e.g. the current sizing parameter, but include a border if requested, e.g. same as points.

Also include a new parameter to override the default colour ramp.

Something that does the equivalent of "colourRamp=value" where "value" is "colour1,count1,colour2,count2,colour3", colours are RGBA hex, and used as defined here:

  • use colour1 when count <= count1
  • use colour2 when count <= count2
  • use colour3 when count > count2
@adam-collins adam-collins self-assigned this Feb 8, 2024
@adam-collins
Copy link
Contributor Author

Observations

  • Resizable grids scaled to a tile pixel resolution has limitations. Bigger grid cells look better. Zooming out is better (tile zoom not map level zoom).
  • I like the polygon edges from the default RenderingHints applied. The appearance varies depending on grid size.
  • Refer to the Java code if you need a reference on how to convert a pixel coordinates to polygon coordinates.
  • Using the old method of rendering so performance will vary more. It all depends on the use case.
  • Stitching tiles together was more trouble than it should have been. I think I found all of the errors, rounding and otherwise. Testing will tell.
  • A demo page was useful for playing with the map. Should put together something public.

3

1
2

adam-collins pushed a commit that referenced this issue Feb 12, 2024
@adam-collins adam-collins mentioned this issue Apr 9, 2024
@adam-collins adam-collins added this to the 3.5.0 milestone Apr 19, 2024
@adam-collins
Copy link
Contributor Author

Received a comment about removing that faint border between cells.

@adam-collins
Copy link
Contributor Author

Any other feedback?

@adam-collins
Copy link
Contributor Author

Removed the border between cells. This is in test for confirmation. example

There was a buffer applied to adjust for the aliased edges. It looks OK in the given example but if you find another where it is not, please provide a link to the incorrect image.

commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant