From 9f80bf93b330622e7f6366501071b46d92b63c3b Mon Sep 17 00:00:00 2001
From: Rita Chen <Rita.Chen@csiro.au>
Date: Wed, 3 Jun 2020 17:18:43 +1000
Subject: [PATCH] #218 convert "true"/"false" String to boolean values as
 intended, code review.

---
 .../controllers/au/org/ala/bie/ExternalSiteController.groovy    | 2 +-
 grails-app/views/species/_names.gsp                             | 2 +-
 grails-app/views/species/show.gsp                               | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/grails-app/controllers/au/org/ala/bie/ExternalSiteController.groovy b/grails-app/controllers/au/org/ala/bie/ExternalSiteController.groovy
index 60ec9ae..ab9deae 100755
--- a/grails-app/controllers/au/org/ala/bie/ExternalSiteController.groovy
+++ b/grails-app/controllers/au/org/ala/bie/ExternalSiteController.groovy
@@ -37,7 +37,7 @@ class ExternalSiteController {
     RateLimiter genbankRateLimiter = RateLimiter.create(3.0) // rate max requests per second (Double)
 
     // by default do not sanitise EOL response
-    boolean sanitiseEol = grailsApplication.config.eol.sanitise ?: "false".toBoolean()
+    boolean sanitiseEol = grailsApplication.config.getProperty("eol.sanitise", Boolean, false)
 
     def index() {}
 
diff --git a/grails-app/views/species/_names.gsp b/grails-app/views/species/_names.gsp
index 034d0de..8c43312 100644
--- a/grails-app/views/species/_names.gsp
+++ b/grails-app/views/species/_names.gsp
@@ -174,7 +174,7 @@
                     </td>
                     <td class="source">
                         <ul>
-                            <g:if test="${grailsApplication.config.vernacularName.pull.showLanguage?:"false".toBoolean()}">
+                            <g:if test="${grailsApplication.config.getProperty("vernacularName.pull.showLanguage", Boolean, false)}">
                                 <li>
                                     <bie:showLanguage lang="${language}"/>
                                 </li>
diff --git a/grails-app/views/species/show.gsp b/grails-app/views/species/show.gsp
index c08622d..50239c1 100644
--- a/grails-app/views/species/show.gsp
+++ b/grails-app/views/species/show.gsp
@@ -102,7 +102,7 @@
             <g:if test="${tc?.taxonConcept?.acceptedConceptName}">
                 <h2><g:link uri="/species/${tc.taxonConcept.acceptedConceptID}">${tc.taxonConcept.acceptedConceptName}</g:link></h2>
             </g:if>
-            <g:if test="${grailsApplication.config.vernacularName.pull.showHeader?:"false".toBoolean() && tc.pullCommonNames}">
+            <g:if test="${grailsApplication.config.getProperty("vernacularName.pull.showHeader", Boolean, false) && tc.pullCommonNames}">
                 <g:each in="${tc.pullCommonNames}" var="cn" status="cni">
                     <g:if test="${cni % 2 == 0}"><g:if test="${cni != 0}"></div></g:if><div class="row"></g:if>
                     <div class="col-md-6"><h2><bie:markLanguage text="${cn.nameString}" lang="${cn.language}" mark="${grailsApplication.config.vernacularName.pull.showLanguage}" tag="${false}"/></h2></div>