-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add userAgent for Alerts #291
Comments
Added to code with config override (
@joe-lipson - would it help to also include "ALA" in the string, so you could check for any ALA services without specifying the app names? E.g. |
Nice! I'm totally fine with just the alerts/[version] format which is in line with other products. ala-alerts fine too but as these are our internal services making requests just to other internal services not sure it's needed, or would there be cross LA requests where this would be useful to know it's coming from ALA alerts? |
@joe-lipson - I'm not sure how you'll be using these values but I thought/guessed you might want to filter all the access_logs for internal requests (or exclude them), when trying to "find stuff". So having the "ala" string might be useful??? As opposed to needing to do an ORed search for |
hmm yeah that would be useful, but it's not a big hassle to OR the UAs in a query if needed, we'd need to update all our services to be ala-[service] before it would work too. I'm happy to just keep it as [service]/[version] |
NW. I've made this a config value, so in the future it could |
Requests from the aws-alerts-prod-2022 instance are coming up with a UA of
Java/11.0.24
Alerts should identify itself like our other services as service/version e.g. ozcam-hub/7.1.0
The text was updated successfully, but these errors were encountered: