Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#290 Added optional S3 data store for BS CSV files #301

Merged
merged 6 commits into from
Oct 8, 2024
Merged

#290 Added optional S3 data store for BS CSV files #301

merged 6 commits into from
Oct 8, 2024

Conversation

nickdos
Copy link
Contributor

@nickdos nickdos commented Oct 7, 2024

@nickdos nickdos linked an issue Oct 7, 2024 that may be closed by this pull request
Add optional S3 usage #290
Open
@nickdos
Revert maven repo order
a809c95 
Had to change due to bad dep being served from nexus.ala.org.au
@nickdos nickdos self-assigned this Oct 7, 2024
@nickdos nickdos added the Biosecurity Alerts for biosecurity species label Oct 7, 2024
qifeng-bai
qifeng-bai reviewed Oct 8, 2024
View reviewed changes
grails-app/services/au/org/ala/alerts/BiosecurityCSVService.groovy Outdated

def config = grailsApplication.config

if (config.getProperty('biosecurity.csv.local.enabled', Boolean, true)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove what? The if (config.getProperty('biosecurity.csv.local.enabled', Boolean, true)) { line? For what reason?

@nickdos
Copy link
Contributor Author

nickdos commented Oct 8, 2024

@bai - most of those comments have been dealt with with fixes. Anything else of note or good to approve?

@nickdos nickdos merged commit ff99736 into develop Oct 8, 2024
1 check passed
@nickdos nickdos deleted the 290-add-optional-s3-usage branch October 8, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qifeng-bai qifeng-bai qifeng-bai approved these changes

@adam-collins adam-collins Awaiting requested review from adam-collins

Assignees

@nickdos nickdos

Labels
Biosecurity Alerts for biosecurity species
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optional S3 usage
2 participants
@nickdos @qifeng-bai