Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query - functionality of "notify" and link with CSV #289

Open
turley85 opened this issue Sep 19, 2024 · 4 comments
Open

Query - functionality of "notify" and link with CSV #289

turley85 opened this issue Sep 19, 2024 · 4 comments
Assignees
Labels
Biosecurity Alerts for biosecurity species help wanted

Comments

@turley85
Copy link

When creating a new alert, when I click "notify" does this add the related alerts to the CSV?

Or will this only occur after the alert is scheduled?

@kylie-m kylie-m self-assigned this Sep 19, 2024
@nickdos nickdos added help wanted Biosecurity Alerts for biosecurity species labels Oct 1, 2024
@nickdos
Copy link
Contributor

nickdos commented Oct 1, 2024

Next to Notify button it says:

"Notify" will send alerts to the subscribers and update the last check date to today

Which is the same as the regular weekly emails - which also updates the "last check date". So CSV is updated in both cases.

@turley85
Copy link
Author

turley85 commented Oct 1, 2024

Ok, this is a problem. As we basically need to use the "notify" button to schedule an alert on a particular day, this is occurring before we add external users to the alert. As such, the CSV is recording data/alerts that were never sent to the external users, which is not what we want.

I think this issue has arisen as we've used the notify function to both schedule an alert, and notify users with no way to actually schedule the day an alert sends right? Happy to talk though this more in our catch up tomorrow.

@nickdos
Copy link
Contributor

nickdos commented Oct 2, 2024

I can confirm it definitely creates a new CSV file when it runs, mirroring what @kylie-m said.

Yes, needs some thought, as there might be implications of doing it the other way - no update of DB and CSV files.

It sounds like the Notify should work the same as Preview but I'm guessing it was done the way it is, for "reasons" (probably technical ones). We might need to wait for Bai to return from leave before committing to a change, just so we don't replay history.

@nickdos
Copy link
Contributor

nickdos commented Oct 3, 2024

Just adding another snippet of info on the notify function. It seems to ignore the "Check alert since" date picker (at least for existing alerts that have run via the schedule) and uses the last check date as the "previous" date. This makes sense as it is updating the database and will mean you will never double-up entries in the CSV file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Biosecurity Alerts for biosecurity species help wanted
Projects
None yet
Development

No branches or pull requests

3 participants