Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when sailing through single land bridges/hexes #224

Open
jt-traub opened this issue Oct 15, 2024 · 1 comment
Open

Bug when sailing through single land bridges/hexes #224

jt-traub opened this issue Oct 15, 2024 · 1 comment
Labels

Comments

@jt-traub
Copy link
Contributor

jt-traub commented Oct 15, 2024

The SailThroughCheck code does not correctly handle PREVENT_SAIL_THROUGH and ALLOW_TRIVIAL_PORTAGE which allows any ship to sail through any single land hex

; nw     /C   \     ne
;   ____/      \____
;  /A   \      /F   \
; /  ~ ~ \____/  ~ ~ \
; \ ~ ~  /D   \ ~ ~  /
;  \____/Thandi\____/
;  /B   \      /G   \
; /  ~ ~ \____/  ~ ~ \
; \ ~ ~  /E   \ ~ ~  /
;  \____/Hynoda\____/
;       \      /H   \
;        \____/  ~ ~ \
;             \ ~ ~  /
; sw           \____/ se

In the above, you can sail from B->D->F though when PREVENT_SAIL_THROUGH is 1 you shouldn't be able to.

@jt-traub
Copy link
Contributor Author

Another report (from a different player) said that in a scenario sailing north->south with ocean->land->ocean they were stopped on the land hex, so I think there is a much more subtle bug here somewhere!!

@jt-traub jt-traub added the bug label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant