Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in JFAC #480

Open
morshedahmed17 opened this issue Sep 26, 2022 · 3 comments
Open

Error in JFAC #480

morshedahmed17 opened this issue Sep 26, 2022 · 3 comments

Comments

@morshedahmed17
Copy link

I set the JFAC to 'CONSTRAINED' and used 'J4' in photolysisConstrained.config and a corresponding fi le with
the constraint data present in the model/constraints/photolysis/

However, I am getting the following error.

image

@rs028
Copy link
Collaborator

rs028 commented Sep 26, 2022

If you have a file called J4 in constraints/photolysis/ (and you have "J4" in the photolysisConstrained.config file) that means you are constraining the photolysis rate J4, but that as no effect on JFAC (**).

If JFAC is constrained, you need a file called JFAC in constraints/photolysis/

(**) the only exception is when J4 is used to calculate JFAC, but that is not your case because you are setting JFAC to CONSTRAINED`.

@morshedahmed17
Copy link
Author

Thanks for your reply. Now, I want to calculate the JFAC. I edited the environmentVariables.config fi le and set JFAC to J4 and J4 is constrained in photolysisConstrained.config and the corresponding constraint file is present in the model/constraints/photolysis/ directory. However, the run stops after a certain time. Please see attached images and the J4 file.

image

image
J4.txt

@rs028
Copy link
Collaborator

rs028 commented Sep 27, 2022

This is most likely the bug same described in #16.
Calculation of JFAC from a measured photolysis rate is difficult for a number of reasons and often causes the model to crash. I would recommend to calculate JFAC offline, create the JFAC file in constraints/photolysis and set JFAC to CONSTRAINED instead of CALC. It's not ideal but until this bug is resolved it is the easiest workaround.

@rs028 rs028 moved this to Photolysis Rates in Roadmap Oct 6, 2022
@rs028 rs028 added this to Roadmap Oct 6, 2022
@rs028 rs028 added this to the version 1.4 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Photolysis Rates
Development

No branches or pull requests

2 participants