New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation of JFAC #478

Open

rs028 opened this issue Sep 26, 2022 · 1 comment

Labels

bug enhancement

Milestone

Collaborator

rs028 commented Sep 26, 2022 •

edited

Loading

There 2 main problems with the calculation of JFAC:

zeros or infinite values created by the division (see also JFAC crashes when calculated from constrained jNO2 #16).
different photolysis rates have different widths (due to different absorption cross sections).

The first is probably solvable with simple modifications to the code (e.g. appropriate threshold for COSX, see #276).

The second requires a different approach and/or a new algorithm to calculate JFAC.

rs028 changed the title ~~There 2 main problems with the calculation of JFAC:~~ Calculation of JFAC

Collaborator Author

rs028 commented Sep 26, 2022

With regard to the second point, this paper https://pubs.rsc.org/en/content/articlehtml/2022/ea/d2ea00072e may be helpful.

rs028 added enhancement bug labels

rs028 added this to the version 1.4 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment