Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasette publish executable issue #117

Closed
Poiuy7312 opened this issue Nov 17, 2023 · 2 comments · Fixed by #118
Closed

Datasette publish executable issue #117

Poiuy7312 opened this issue Nov 17, 2023 · 2 comments · Fixed by #118
Assignees
Labels
bug Something isn't working

Comments

@Poiuy7312
Copy link
Collaborator

Poiuy7312 commented Nov 17, 2023

This is a very similar bug as #51 for the datasette-publish command this only an issue on windows

To Reproduce
Steps to reproduce the behavior:
Simply run the datasette-publish command on a windows OS and it won't be able to find the executable for datasette

Expected behavior
This shouldn't happen it should be able to find the executable this is an issue because of windows storing executables in a different way than Linux and Mac

@Poiuy7312 Poiuy7312 added the bug Something isn't working label Nov 17, 2023
@gkapfham
Copy link
Collaborator

Hello @Poiuy7312, yes, I agree that this is an issue! Do you agree that it is connected to the fact that it is not finding the executable in the virtual environment due to a path issue? If it something different, could you please give me an update on what you think is the key problem and how to solve it?

@Poiuy7312
Copy link
Collaborator Author

Hello @Poiuy7312, yes, I agree that this is an issue! Do you agree that it is connected to the fact that it is not finding the executable in the virtual environment due to a path issue? If it something different, could you please give me an update on what you think is the key problem and how to solve it?

I believe it's the same as issue #51 and the fix should be pretty simple as it should just require sending the start_datasette_server function the OS of the computer when using the publish command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants