Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor of 8/9 expressed as 0.8 instead of 0.89 #24

Open
cgilhuly opened this issue Jan 21, 2020 · 1 comment
Open

Factor of 8/9 expressed as 0.8 instead of 0.89 #24

cgilhuly opened this issue Jan 21, 2020 · 1 comment

Comments

@cgilhuly
Copy link
Collaborator

Maybe there's another numerical factor involved that I'm not aware of, but I think there may be a small typo here:

sig_adu = np.sqrt(biweight_midvariance(im_fluct_in)) * 0.80 # 8/9 is area correction

@AstroJacobLi
Copy link
Owner

I did some tests on this factor: generate an image with Gaussian noise, mask out some areas, calculate the SB-contrast using this code, and compare the result with the input Gaussian noise. Although an area correction factor 8/9 sounds more reasonable, I found that a correction factor of 0.80 works better empirically. Anyway, I don't think it will make a huge difference regarding the SB limit (-2.5 * log(0.8/0.89) = 0.1 mag). Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants