Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting new data #28

Open
wfengk opened this issue Sep 30, 2017 · 2 comments
Open

Getting new data #28

wfengk opened this issue Sep 30, 2017 · 2 comments

Comments

@wfengk
Copy link
Collaborator

wfengk commented Sep 30, 2017

Need feedback

So right now we are at about ~1000 restaurants, and we will need to get more data eventually.

I was thinking that each time we use the search to find new restaurants, we could query yelp and add that new restaurant to our database

asktoni

Thoughts?

@RedTn
Copy link

RedTn commented Oct 13, 2017

Hmm, it seems like the crawler should be doing this. From a technical standpoint, other than the 3 RTT calls for each missing restaurant (Client -> Ask Toni, Client -> Yelp, Client -> Ask Toni), the comparison logic is going to be way too complex. Restaurant with same names, then compare address, what if we want to overwrite AskToni version?

@wfengk
Copy link
Collaborator Author

wfengk commented Oct 22, 2017

I could build the Yelp querying functionality as a REST endpoint? that way you just need to make one additional call?

My problem with the crawler is that I wont get any more data after the 1000 restaurants (yelp cap) unless I search for one specifically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants