Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Don't trigger string_has_extra_arguments when original string is missing #57

Open
marcelofabri opened this issue Aug 21, 2024 · 1 comment · May be fixed by #58
Open

[iOS] Don't trigger string_has_extra_arguments when original string is missing #57

marcelofabri opened this issue Aug 21, 2024 · 1 comment · May be fixed by #58

Comments

@marcelofabri
Copy link
Contributor

marcelofabri commented Aug 21, 2024 •
edited
Loading

Looks like string_has_extra_arguments can be triggered if a string with arguments is present in a translated strings file, but missing from the original one.

IMO this should be reported with a new "problem" type: extra_key_in_translation instead Looks like Android already has KeyMissingFromBase -- we should use it for iOS as well

This is happening for iOS, not sure if the same issue is present on Android.
@marcelofabri marcelofabri changed the title Don't trigger string_has_extra_arguments when original string is missing [iOS] Don't trigger string_has_extra_arguments when original string is missing Aug 21, 2024
marcelofabri added a commit to marcelofabri/locheck that referenced this issue Aug 21, 2024
@marcelofabri
Trigger key_missing_from_base for iOS
fbc77f2 
Fixes Asana#57
@marcelofabri marcelofabri linked a pull request Aug 21, 2024 that will close this issue
Open
@marcelofabri
Copy link
Contributor Author

I think this is actually the same as #42?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trigger key_missing_from_base for iOS marcelofabri/locheck
1 participant
@marcelofabri