Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for message subject lines in view page #2

Open
samcamwilliams opened this issue Apr 12, 2019 · 8 comments
Open

Add support for message subject lines in view page #2

samcamwilliams opened this issue Apr 12, 2019 · 8 comments
Labels
enhancement New feature or request gitcoin-bounty A bounty (in ETH) is available on gitcoin.co for fixing this issue.

Comments

@samcamwilliams
Copy link
Contributor

We should add support for showing message subject lines, rather than transaction identifiers for messages on the message 'view' page.

I propose that we use a simple JSON structure to describe messages:
{"subject":"SUBJECT_LINE","body":"MESSAGE_BODY"}

This format should be extensible with extra fields (an attachments list, for example) at some later point.

In order to implement this we need to:

  1. Bump the App-Version tag (to 0.0.2) or add a specific Message-Format tag (starting from 2). See here.
  2. Add parsing code to crypto.js converting old-style messages into JSON of the new format ({"subject": "[TXID_HERE]", "body":"[OLD_MESSAGE_CONTENTS_HERE]"}). Return new message format transactions as JSON objects.
  3. Add rendering code to view.js that takes the new JSON object and puts the title and text body in the appropriate places.
@samcamwilliams samcamwilliams added enhancement New feature or request gitcoin-bounty A bounty (in ETH) is available on gitcoin.co for fixing this issue. labels Apr 12, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.73 ETH (119.92 USD @ $164.27/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Apr 12, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 11 months, 1 week from now.
Please review their action plans below:

1) prabodhmeshram has applied to start work (Funders only: approve worker | reject worker).

@samcamwilliams I am interested to work on this issue if this is open for work.

Learn more on the Gitcoin Issue Details page.

2) codi45 has been approved to start work.

i added new format to crypto.js and field for the subject line in permamail
tested ok

Learn more on the Gitcoin Issue Details page.

@aahutsal
Copy link

@samcamwilliams sounds easy. I'd participate

@gitcoinbot
Copy link

@codi45 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@codi45
Copy link
Contributor

codi45 commented May 2, 2019

Hi

i still working on it

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.73 ETH (122.17 USD @ $167.35/ETH) has been submitted by:

  1. @codi45

@samcamwilliams please take a look at the submitted work:


@gitcoinbot
Copy link

Cypherpunk Mind ⚡️ A *Cypherpunk Mind* Kudos has been sent to @codi45 for this issue from @samcamwilliams. ⚡️

Nice work @codi45!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.73 ETH (122.17 USD @ $167.35/ETH) attached to this issue has been approved & issued to @codi45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gitcoin-bounty A bounty (in ETH) is available on gitcoin.co for fixing this issue.
Projects
None yet
Development

No branches or pull requests

4 participants