-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for message subject lines in view page #2
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 0.73 ETH (119.92 USD @ $164.27/ETH) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 11 months, 1 week from now. 1) prabodhmeshram has applied to start work (Funders only: approve worker | reject worker). @samcamwilliams I am interested to work on this issue if this is open for work. Learn more on the Gitcoin Issue Details page. 2) codi45 has been approved to start work. i added new format to crypto.js and field for the subject line in permamail Learn more on the Gitcoin Issue Details page. |
@samcamwilliams sounds easy. I'd participate |
@codi45 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Hi i still working on it |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 0.73 ETH (122.17 USD @ $167.35/ETH) has been submitted by: @samcamwilliams please take a look at the submitted work:
|
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 0.73 ETH (122.17 USD @ $167.35/ETH) attached to this issue has been approved & issued to @codi45.
|
We should add support for showing message subject lines, rather than transaction identifiers for messages on the message 'view' page.
I propose that we use a simple JSON structure to describe messages:
{"subject":"SUBJECT_LINE","body":"MESSAGE_BODY"}
This format should be extensible with extra fields (an attachments list, for example) at some later point.
In order to implement this we need to:
App-Version
tag (to0.0.2
) or add a specificMessage-Format
tag (starting from 2). See here.{"subject": "[TXID_HERE]", "body":"[OLD_MESSAGE_CONTENTS_HERE]"}
). Return new message format transactions as JSON objects.The text was updated successfully, but these errors were encountered: