Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Indefinite repeat/pin item and do not dequeue (Generate Forever, possibly ordered) #235

Open
Nyxeka opened this issue Apr 2, 2024 · 1 comment

Comments

@Nyxeka
Copy link

Nyxeka commented Apr 2, 2024

It would be pretty cool to use this as a general ongoing-job-manager with the webui.

Basically, there would be a button in both the queue history and active queue:

image

The button would "Pin" a task to the queue. On complete, the item would then simply move to the bottom of the queue, rather than being dequeued.

This would be quite useful if queued tasks were something that can be managed from different clients for a single user (phone, webui on desktop, or even remote).

This is pretty much directly related to the built-in "Generate forever" feature.
image

The advantage is that instead of blocking the queue for 8000 upcoming images for a single batch, you can just continuously generate. Stopping the queue would of course be as simple as unpinning the task (or hitting pause, etc...)

I will likely take a quick attempt at this, figured it may be useful for others as well.

Nyxeka pushed a commit to Nyxeka/sd-webui-agent-scheduler that referenced this issue Apr 2, 2024
- add new icon for pinned tasks
- add api do_pin_and_request, pin, unpin
- add pin and run button to history tab
- add pin button to pending tab
- allow modifying of pending tasks when they are pinned
Nyxeka pushed a commit to Nyxeka/sd-webui-agent-scheduler that referenced this issue Apr 2, 2024
- add new icon for pinned tasks
- add api do_pin_and_request, pin, unpin
- add pin and run button to history tab
- add pin button to pending tab
- allow modifying of pending tasks when they are pinned
Nyxeka added a commit to Nyxeka/sd-webui-agent-scheduler that referenced this issue Apr 2, 2024
- add new icon for pinned tasks
- add api do_pin_and_request, pin, unpin
- add pin and run button to history tab
- add pin button to pending tab
- allow modifying of pending tasks when they are pinned
@Nyxeka
Copy link
Author

Nyxeka commented Apr 2, 2024

implemented here https://github.com/Nyxeka/sd-webui-agent-scheduler/tree/nyxeka/add_pin_functionality

Disclaimer: I've never used typescript/js before really, there are likely bugs, but it seems to work.

Not sure if it's an existing issue but if I queue up a task and then cancel it immediately, switching tabs and then switching back has the task show up again.

barring all of this I'd have opened a PR... Let me know otherwise if it seems useful.

chrome_NI2VKoQNWK
chrome_HhMLRQmpup

default behaviour is that it will run unpinned tasks first, then run the pinned tasks.

Nyxeka added a commit to Nyxeka/sd-webui-agent-scheduler that referenced this issue Apr 2, 2024
- add new icon for pinned tasks
- add api do_pin_and_request, pin, unpin
- add pin and run button to history tab
- add pin button to pending tab
- allow modifying of pending tasks when they are pinned
Nyxeka added a commit to Nyxeka/sd-webui-agent-scheduler that referenced this issue Apr 2, 2024
- add new icon for pinned tasks
- add api do_pin_and_request, pin, unpin
- add pin and run button to history tab
- add pin button to pending tab
- allow modifying of pending tasks when they are pinned
Nyxeka added a commit to Nyxeka/sd-webui-agent-scheduler that referenced this issue Apr 2, 2024
- add new icon for pinned tasks
- add api do_pin_and_request, pin, unpin
- add pin and run button to history tab
- add pin button to pending tab
- allow modifying of pending tasks when they are pinned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant