Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User data interface and other changes #123

Merged
merged 23 commits into from
Apr 26, 2024
Merged

Conversation

MarcosBarrilVillaverde
Copy link

Changes in the api gateway, changes in the model of the user stored data and added new interface to check user data.

validateRequiredFields(req, ['id', 'points', 'username', 'questions', 'avgtime']);

// Find user by username in the database
let user = await User.findOne({ username: req.body.username });

Check failure

Code scanning / SonarCloud

NoSQL operations should not be vulnerable to injection attacks High

Change this code to not construct database queries directly from user-controlled data. See more on SonarCloud
Copy link

@AbelMH1 AbelMH1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que solo ví ese detalle, el resto está para mergear

apisgatewayservice/monitoring/prometheus/prometheus.yml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
40.9% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@AbelMH1 AbelMH1 merged commit 3356971 into develop Apr 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants