Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate attributes with ES6 #296

Closed
2 tasks done
ArnaudBuchholz opened this issue Dec 5, 2018 · 7 comments
Closed
2 tasks done

Integrate attributes with ES6 #296

ArnaudBuchholz opened this issue Dec 5, 2018 · 7 comments

Comments

@ArnaudBuchholz
Copy link
Owner

ArnaudBuchholz commented Dec 5, 2018

Part of #222, #303

As a developer, I want to use attributes in an ES6 class declaration because I don't want to use gpf.define

Acceptance criterias

  • It should be able to create a class (using Function or class) and then pass it to a method that will read and use attributes
  • It should work with inheritance
@ArnaudBuchholz ArnaudBuchholz added this to the 0.2.9: TBD milestone Dec 5, 2018
@ArnaudBuchholz ArnaudBuchholz self-assigned this Dec 5, 2018
ArnaudBuchholz added a commit that referenced this issue Dec 6, 2018
ArnaudBuchholz added a commit that referenced this issue Dec 6, 2018
ArnaudBuchholz added a commit that referenced this issue Dec 6, 2018
@ArnaudBuchholz
Copy link
Owner Author

One idea could be to simulate ES6 decorators by having a 'sort of' transpiler plugged into:

@ArnaudBuchholz
Copy link
Owner Author

Actually, only gpf.require.define will be adapted since it is compatible cross platform.

@ArnaudBuchholz
Copy link
Owner Author

ArnaudBuchholz commented Feb 14, 2019

Used babel-eslint on specific folders only (since it breaks the no-unused-vars rule)

ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 25, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 26, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 26, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 26, 2019
ArnaudBuchholz added a commit that referenced this issue Feb 26, 2019
@ArnaudBuchholz
Copy link
Owner Author

Had to deeply refactor the way entityDefinition are built and provided some for standard objects

@ArnaudBuchholz
Copy link
Owner Author

Need to improve class definition importing:

  • Create a sub class of entity definition that does not validate name

@ArnaudBuchholz
Copy link
Owner Author

_GpfImportedClassDefinition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant