Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes restriction #282

Closed
4 tasks done
ArnaudBuchholz opened this issue Aug 24, 2018 · 1 comment
Closed
4 tasks done

Attributes restriction #282

ArnaudBuchholz opened this issue Aug 24, 2018 · 1 comment
Assignees
@ArnaudBuchholz
Labels
User Story
Milestone
Release 0.2.8: Se...

Comments

@ArnaudBuchholz
Copy link
Owner

ArnaudBuchholz commented Aug 24, 2018 •
edited
Loading

Part of EPIC #222

As a developer, I want to ensure that attributes are used as intended to avoid coding errors and simplify adoption

Acceptance criteria:

  • An attribute qualifies an attribute class to be used on instances of a specific base only (by extension this could be used to restrict on instance of gpf.attributes.Attribute). This attribute can't be used on a member, only on a class. It should fail otherwise.
  • An attribute qualifies an attribute class to be used on class members only
  • An attribute qualifies an attribute class to be used on class only
  • An attribute qualifies an attribute class to be used only once at the given level
@ArnaudBuchholz ArnaudBuchholz added this to the Release 0.2.8: TBD milestone Aug 24, 2018
@ArnaudBuchholz ArnaudBuchholz self-assigned this Aug 24, 2018
ArnaudBuchholz added a commit that referenced this issue Aug 24, 2018
@ArnaudBuchholz
Assessing usability (#282)
2e32974
ArnaudBuchholz added a commit that referenced this issue Aug 27, 2018
@ArnaudBuchholz
Renaming tests (#282)
3bc92ed
ArnaudBuchholz added a commit that referenced this issue Aug 27, 2018
@ArnaudBuchholz
Initial implementation (#282)
8e41b1d
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Experimenting check specification on attribute (#282)
b837ced
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Implementing check WIP (#282)
110321d
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Attributes are collected sooner (#282)
87a70a3
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Attributes are collected sooner and checked (#282)
7444710
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Collect own attributes (#282)
60f6cb7
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Linter fixes (#282)
3a55797
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Attributes check helpers (#282)
8f41c7c
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Adds new checks (#282)
f3771f9
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Normalizes the $attribute usage (#282)
76644e6
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Fixes the tests (#282)
a255f01
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Cleaning (#282)
5b0f108
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Check the base class (#282)
808791e
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
WIP (#282) - fails the build
a2dd968
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Adding the build hoook (#282)
549ebd9
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Adding the build hook (#282)
ec48732
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Factorizes the forOwnAttributes (#282)
92d65ef
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Factorizes the forOwnAttributes (#282)
257aabb
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Implements sub check (#282)
7198466
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Linter fix (#282)
b61caac
ArnaudBuchholz added a commit that referenced this issue Aug 28, 2018
@ArnaudBuchholz
Improves maintainability (#282)
09f67a2
ArnaudBuchholz added a commit that referenced this issue Aug 29, 2018
@ArnaudBuchholz
Base class for attributes dedicated to attributes (#282)
5c603b2
ArnaudBuchholz added a commit that referenced this issue Aug 29, 2018
@ArnaudBuchholz
Empty line (#282)
b313cc9
ArnaudBuchholz added a commit that referenced this issue Aug 29, 2018
@ArnaudBuchholz
Rely on AttributeAttribute (#282)
35a04c6
ArnaudBuchholz added a commit that referenced this issue Aug 29, 2018
@ArnaudBuchholz
Class attribute tests (#282)
c3f51fe
@ArnaudBuchholz ArnaudBuchholz reopened this Sep 6, 2018
ArnaudBuchholz added a commit that referenced this issue Sep 6, 2018
@ArnaudBuchholz
Unique attribute (#282)
705c6d6
ArnaudBuchholz added a commit that referenced this issue Sep 6, 2018
@ArnaudBuchholz
Unique attribute (#282)
5333807
ArnaudBuchholz added a commit that referenced this issue Sep 6, 2018
@ArnaudBuchholz
Unique attribute (#282)
bcd576c
ArnaudBuchholz added a commit that referenced this issue Sep 7, 2018
@ArnaudBuchholz
Sets the name of the generated error class (ease debugging) (#282)
e4d12ce
ArnaudBuchholz added a commit that referenced this issue Sep 7, 2018
@ArnaudBuchholz
Linter error (#282)
f194369
ArnaudBuchholz added a commit that referenced this issue Sep 7, 2018
@ArnaudBuchholz
Unique attribute (#282)
f57e874
ArnaudBuchholz added a commit that referenced this issue Sep 7, 2018
@ArnaudBuchholz
Need the target attribute (#282)
e8e113d
ArnaudBuchholz added a commit that referenced this issue Sep 7, 2018
@ArnaudBuchholz
Applies the check (#282)
6e04b20
ArnaudBuchholz added a commit that referenced this issue Sep 7, 2018
@ArnaudBuchholz
Proper tests (#282)
8af49e0
ArnaudBuchholz added a commit that referenced this issue Sep 7, 2018
@ArnaudBuchholz
Enables UniqueAttribute (#282)
a8b83d5
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Improves maintainability (#282)
1d88626
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Documentation (#282)
34eff6d
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
New dependencies (#282)
25dd93c
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Uniqueness of AttributeAttribute (#282)
bbdf179
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Documentation (#282)
174b953
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Documentation (#282)
07c325d
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Documentation (#282)
ea51456
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Check uniqueness (#282)
7a018af
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Check uniqueness (#282)
1b664e4
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Check uniqueness (#282)
206d732
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Fixes DeepScan error (#282)
a3e4dca
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Singleton (#282)
f595d7f
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Singleton (#282)
cd89727
ArnaudBuchholz added a commit that referenced this issue Sep 8, 2018
@ArnaudBuchholz
Singleton (#282)
5cefe89
@ArnaudBuchholz
Copy link
Owner Author

Also made ClassAttribute, MemberAttribute & UniqueAttribute singletons

ArnaudBuchholz added a commit that referenced this issue Sep 10, 2018
@ArnaudBuchholz
Documentation (#282)
992d0de
ArnaudBuchholz added a commit that referenced this issue Sep 10, 2018
@ArnaudBuchholz
Documentation (#282)
5ac8836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArnaudBuchholz ArnaudBuchholz

Labels
User Story
Projects
None yet
Milestone
Release 0.2.8: Serialization attributes
Development

No branches or pull requests
1 participant
@ArnaudBuchholz