Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6] utils: Use of native BigInt in BigNumber library breaks support for Safari #3424

Closed
deanpress opened this issue Jan 26, 2020 · 3 comments

Comments

@deanpress
Copy link
Contributor

deanpress commented Jan 26, 2020

Somewhat related to #3423

Native BigInt (which is used in the toBigNumber() method in the @arkecosystem/utils big-number.ts library) is not yet supported in all popular browsers (e.g. Safari).

Possible Solution

Replace native BigInt with JSBI BigInt in utils: https://github.com/GoogleChromeLabs/jsbi.

The only thing it doesn't support is floats, but from what I observed that isn't supported in the current BigNumber implementation either.

Your Environment

  • Version used: 2.6.0-next.9
  • Browser Version: Safari 13
@ghost
Copy link

ghost commented Jan 26, 2020

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@deanpress deanpress changed the title [2.6] crypto package: Use of native BigInt in BigNumber library breaks support for Safari [2.6] utils: Use of native BigInt in BigNumber library breaks support for Safari Jan 26, 2020
@deanpress
Copy link
Contributor Author

Closed to move to ArkEcosystem/utils#60

@ghost
Copy link

ghost commented Jan 26, 2020

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant