Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise MAVFTP upload to improve performance #3229

Open
rmackay9 opened this issue Nov 11, 2023 · 1 comment
Open

Optimise MAVFTP upload to improve performance #3229

rmackay9 opened this issue Nov 11, 2023 · 1 comment

Comments

@rmackay9
Copy link
Contributor

rmackay9 commented Nov 11, 2023

A Copter-4.4 user reported in this discussion that manually uploading a terrain file (produced using https://terrain.ardupilot.org/) using MP's MAVFTP screen is extremely slow. In my tests it was able to upload only 1MB of a 30MB file in 5min.
image

Performance was the same whether Copter-4.4 or 4.5.0-dev was used. I tested on a CubeOrangePlus.

Surprisingly though MP does better than MAVProxy which fails completely (at least on windows). Here is the corresponding MAVProxy issue ArduPilot/MAVProxy#1270

In case it helps, these messages scrolled by on the MP console a lot.
image

image

@rmackay9 rmackay9 changed the title MAVFTP extremely slow MAVFTP upload extremely slow Nov 14, 2023
@rmackay9 rmackay9 changed the title MAVFTP upload extremely slow Optimise MAVFTP upload to improve performance Nov 14, 2023
@rmackay9
Copy link
Contributor Author

I've changed the title to reflect that this is no longer considered a bug but rather an enhancement request.

On the Nov 14th dev call we discussed with Tridge and discovered that MAVFTP's implementation (both within the GCSs and the flight code) has been optimised for downloading (e.g. from the autopilot->GCS) but not for uploading (e.g. GCS->autopilot).

There were two suggestions for improving peformance:

  1. send multiple MAVFTP messages from the GCS to the autopilot without waiting for a response.
  2. create a new MAVLink message to send longer messages just like we do for downloading. Currently it seems the MAVFTP messages are only 80bytes long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant