Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recycling Unit Test #1021

Open
KiwiHawk opened this issue Dec 18, 2024 · 1 comment
Open

Recycling Unit Test #1021

KiwiHawk opened this issue Dec 18, 2024 · 1 comment
Labels
Angels Unit Tests unit test related Factorio 2.0 Changes that depend on Factorio 2.0

Comments

@KiwiHawk
Copy link
Collaborator

Recycling Recipes Unit Test

Background

Recycling recipes are automatically created by the Quality mod in data-updates stage. This runs before community mods have a change to update recipe ingredients as official mods run first. This leads to a common scenario of the base recipe and recycling recipe being out of sync.

Idea

Create a new unit test. It should cycle through all recycling recipes. For each recipe, match it up to it's base recipe. Compare the ingredients of the base recipe with the products of the recycling recipe. The recycling recipe should produce the same items or it should recycle to itself.

@KiwiHawk KiwiHawk added Angels Unit Tests unit test related Factorio 2.0 Changes that depend on Factorio 2.0 labels Dec 18, 2024
@KiwiHawk
Copy link
Collaborator Author

I have submitted a request to move recycling recipe generation to data-final-fixes. This would make the error less common but not eliminate it entirely (recipe changes in data-final-fixes would also need to update recycling recipes).

https://forums.factorio.com/viewtopic.php?f=28&t=124656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angels Unit Tests unit test related Factorio 2.0 Changes that depend on Factorio 2.0
Projects
None yet
Development

No branches or pull requests

1 participant