Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0-prep] amount = "water" in ingredient patch is invalid #1003

Open
kirazy opened this issue Aug 1, 2024 · 0 comments
Open

[2.0-prep] amount = "water" in ingredient patch is invalid #1003

kirazy opened this issue Aug 1, 2024 · 0 comments

Comments

@kirazy
Copy link
Contributor

kirazy commented Aug 1, 2024

Impacts 2.0-prep branch.

Issue:
With the removal of normal and expensive ingredients, the optional ingredients field is now required. Which means that this block of code now gets processed by the recipe builder (RB.build and check_ingredients):

OV.patch_recipes({
{ name = "water-electrolysis", ingredients = { { name = "water-purified", type = "fluid", amount = "water" } } },
{ name = "nitric-acid", ingredients = { { name = "water-purified", type = "fluid", amount = "water" } } },
{ name = "sulfuric-acid-2", ingredients = { { name = "water-purified", type = "fluid", amount = "water" } } },
{
name = "petroleum-gas-cracking",
ingredients = { { name = "water-purified", type = "fluid", amount = "water" } },
},
{ name = "coal-cracking", ingredients = { { name = "water-purified", type = "fluid", amount = "water" } } },
{
name = "lithium-water-electrolysis",
ingredients = { { name = "water-purified", type = "fluid", amount = "water" } },
},
{ name = "explosives", ingredients = { { name = "water-purified", type = "fluid", amount = "water" } } },
{ name = "sulfur", ingredients = { { name = "water-purified", type = "fluid", amount = "water" } } },
{ name = "sulfuric-acid", ingredients = { { name = "water-purified", type = "fluid", amount = "water" } } },
{ name = "heavy-oil-cracking", ingredients = { { name = "water-purified", type = "fluid", amount = "water" } } },
{ name = "light-oil-cracking", ingredients = { { name = "water-purified", type = "fluid", amount = "water" } } },
{
name = "advanced-oil-processing",
ingredients = { { name = "water-purified", type = "fluid", amount = "water" } },
},
})

Whereupon it attempts to multiply a string "water" by a number and throws an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant