Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STORY] Change side_car_exts to side_car_types #51

Closed
2 tasks
tclose opened this issue Mar 29, 2022 · 2 comments
Closed
2 tasks

[STORY] Change side_car_exts to side_car_types #51

tclose opened this issue Mar 29, 2022 · 2 comments
Assignees
@tclose
Labels
analysis-design Complex analysis workflow epic deep Requires advanced framework/domain-specific knowledge pipelines story a unit of work
Milestone
Beta

Comments

@tclose
Copy link
Contributor

tclose commented Mar 29, 2022 •
edited
Loading

Description

Instead of specifying side-cars via their extension, it would be more flexible/work better with passing FileGroup objects to workflow, if we specified them by their individual types, e.g.

class NiftiX(WithSideCars, Nifti):
    
    side_car_types = (Json,)

Acceptance criteria

  • 1. side-cars are specified by type rather than extension
  • 2. new behaviour is covered by unittests
@tclose tclose added this to the 2.0.0a milestone Mar 29, 2022
@tclose tclose moved this to Backlog in AIS Master Project Jun 20, 2022
@tclose tclose added story a unit of work incomplete-desc and removed enhancement labels Jun 21, 2022
@tclose tclose changed the title Change side_car_exts to side_car_types [STORY] Change side_car_exts to side_car_types Jun 21, 2022
@tclose tclose mentioned this issue Jun 21, 2022
Open
8 tasks
@tclose tclose added mid-level Requires moderate framework/domain-specific knowledge deep Requires advanced framework/domain-specific knowledge analysis-design Complex analysis workflow epic and removed mid-level Requires moderate framework/domain-specific knowledge incomplete-desc labels Jun 21, 2022
@tclose tclose modified the milestones: 2.0b, 2.0 Jun 23, 2022
@tclose tclose self-assigned this Jun 27, 2022
@tclose tclose removed 1pt labels Aug 9, 2022
@tclose
Copy link
Contributor Author

tclose commented Mar 21, 2023

These should both be dropped in favour of just using required path properties

@tclose
Copy link
Contributor Author

tclose commented Aug 21, 2023

done

@tclose tclose closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tclose tclose

Labels
analysis-design Complex analysis workflow epic deep Requires advanced framework/domain-specific knowledge pipelines story a unit of work
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
1 participant
@tclose