From 485ca120c102fac24373b7fd2935494683c6a54a Mon Sep 17 00:00:00 2001
From: shartte <shartte@users.noreply.github.com>
Date: Sat, 27 Jul 2024 13:16:54 +0200
Subject: [PATCH] Fix "open guide" hotkey not working for items in Emi because
 they were changing each frame (#7965) (#8062)

Fixes #7877

(cherry picked from commit 40583e4c595b3ffae177098022125bd8c2032b55)
---
 .../guidebook/hotkey/OpenGuideHotkey.java      | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/main/java/appeng/client/guidebook/hotkey/OpenGuideHotkey.java b/src/main/java/appeng/client/guidebook/hotkey/OpenGuideHotkey.java
index 90fe3204a0b..168454ca1f5 100644
--- a/src/main/java/appeng/client/guidebook/hotkey/OpenGuideHotkey.java
+++ b/src/main/java/appeng/client/guidebook/hotkey/OpenGuideHotkey.java
@@ -1,6 +1,7 @@
 package appeng.client.guidebook.hotkey;
 
 import java.util.List;
+import java.util.Objects;
 
 import com.google.common.base.Strings;
 import com.mojang.blaze3d.platform.InputConstants;
@@ -46,8 +47,8 @@ public final class OpenGuideHotkey {
 
     private static boolean newTick = true;
 
-    // The last itemstack the tooltip was being shown for
-    private static ItemStack lastStack;
+    // The previous item the tooltip was being shown for
+    private static ResourceLocation previousItemId;
     @Nullable
     private static PageAnchor guidebookPage;
     // Full ticks since the button was held (reduces slowly when not held)
@@ -137,15 +138,16 @@ private static Component makeProgressBar(float progress) {
     }
 
     private static void update(ItemStack itemStack) {
-        if (itemStack != lastStack) {
-            lastStack = itemStack;
+        var itemId = itemStack.getItemHolder()
+                .unwrapKey()
+                .map(ResourceKey::location)
+                .orElse(null);
+
+        if (!Objects.equals(itemId, previousItemId)) {
+            previousItemId = itemId;
             guidebookPage = null;
             ticksKeyHeld = 0;
 
-            var itemId = itemStack.getItemHolder()
-                    .unwrapKey()
-                    .map(ResourceKey::location)
-                    .orElse(null);
             if (itemId == null) {
                 return;
             }