Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading ads without an Activity context for All Adapters #729

Open
ibrahimeywin opened this issue Oct 16, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@ibrahimeywin
Copy link

Feature Description

Hello,

Recently, the ability to load ads without an activity context was integrated for the AdMob and GAM adapters.

Could you please clarify if there are plans to extend this functionality to other adapters, and if so, is there an estimated release date? Our ANR rate has increased significantly in the latest release, and we suspect it may be related to this issue.

We need to realase urgent new version to decrase ANR's.
Thank you in advance for any information you can provide.

@ibrahimeywin ibrahimeywin added the enhancement New feature or request label Oct 16, 2024
@thomasmso
Copy link
Member

@ibrahimeywin - it really depends on the mediated SDK's requirements. Is there a specific adapter that you are inquiring for?

@ibrahimeywin
Copy link
Author

Thank you so much for your quick response!

These are the most critical adapters for us.

Admob
Gam
Meta
Liftoff
DTExchange(Fyber-Inneractive)
Amazon
Pangle
Verve/Pubnative
Bidmachine
Inmobi
Mintegral
Applovin

@thomasmso
Copy link
Member

Generally speaking, using an Activity instance shouldn't cause ANRs, but we're in the process of combing through the adapters to see where else we can stop passing in Activity references to mediated SDKs (which might hold a reference to it longer than necessary).

@ibrahimeywin
Copy link
Author

With version 12.5.0, we send applicationcontext since it is not mandatory to use activity in load requests.

ss

However, I think this causes problems in some adapters.
I see that there was a fix for GAM and Google a while ago, will there be an improvement for other adapters in the near future?

ss2

@ibrahimeywin
Copy link
Author

Hi @Kennyhbui ,

Will there be a development for other adapters in the near future?
It is very important that other adapters can load without activity context.

ss

@Kennyhbui
Copy link

Hi @ibrahimeywin,

I'm currently finalizing fixes to ensure there are no issues in the adapters when loading ads with an activity context. These changes will be available soon.

@ibrahimeywin
Copy link
Author

Hi @Kennyhbui

Thank you very much for the information. Then we will postpone our update until you complete the fixes. Originally, our plan was to release the update today.

@ibrahimeywin
Copy link
Author

Hi @Kennyhbui , is there any date for the update?

@Kennyhbui
Copy link

Hi @ibrahimeywin, the updates should be ready early next week. I'll let you know once they're available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants