Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup the Polly codebase] Warning CA1062 #2215

Closed
26 tasks done
Zombach opened this issue Jul 19, 2024 · 1 comment
Closed
26 tasks done

[Cleanup the Polly codebase] Warning CA1062 #2215

Zombach opened this issue Jul 19, 2024 · 1 comment

Comments

@Zombach
Copy link
Contributor

Zombach commented Jul 19, 2024

Checklist

The issue or feature being addressed

#1290 Cleanup codebase
Namely suppress CA1062 Validate arguments in the code or fix the warning

Details on the issue fix or feature implementation

Since the task is big,
This must be done in several stages.
The first stage is warning suppression.
Then each next PR - processing of one file and adding tests

Warning suppression must be removed for each file
#pragma warning disable CA1062 // Validate arguments of public methods
Next, make changes to the code, checking for null for the necessary arguments.
Next, add tests, if necessary.

@Zombach
Copy link
Contributor Author

Zombach commented Jul 23, 2024

@martincostello Thanks for the prompt review

@Zombach Zombach closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant