Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

500 status code should not be considered as transient error #32

Open
BDavidRamesh opened this issue Jun 15, 2022 · 1 comment
Open

500 status code should not be considered as transient error #32

BDavidRamesh opened this issue Jun 15, 2022 · 1 comment

Comments

@BDavidRamesh
Copy link

BDavidRamesh commented Jun 15, 2022

Current Problem Statement:
the current 5XX check includes 500 which is not TransientError,
500 error requires code changes or query changes by the dev team.

  1. so retry for 500 always returns 500
  2. if there is dependency on Service-1 for 3 different Api calls for 3 different workflows, opening circuit for 500 error on Api-1 makes the entire Service unavailable.

Proposed Fix:
response status code should be ">500" instead of ">=500"

@BDavidRamesh BDavidRamesh changed the title 500 is not transient error 500 status code should not be considered as transient error Jun 15, 2022
@savbace
Copy link

savbace commented Mar 15, 2023

Any discussion around this a little bit controversial topic? :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants