Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use System.Text.Json? #14

Open
ylibrach opened this issue Jan 3, 2020 · 3 comments
Open

Update to use System.Text.Json? #14

ylibrach opened this issue Jan 3, 2020 · 3 comments

Comments

@ylibrach
Copy link

ylibrach commented Jan 3, 2020

Now that System.Text.Json is robust enough for widespread use, this library should either be updated to support it, or perhaps a separate package created to distinguish between Newtonsoft and STJ libraries?

@reisenberger
Copy link
Member

Now that System.Text.Json is robust enough for widespread use, this library should either be updated to support it,
or perhaps a separate package created to distinguish between Newtonsoft and STJ libraries?

@ylibrach Yes, absolutely!

Do you have time to contribute that? Should be easy, as the existing implementation is barely 40 lines-of-code, and the tests only 170loc. This logic is as little as take some settings in the ctor (would switch these to System.Text.Json.JsonSerializerOptions) and call to serialize and deserialize.

If you (or anyone else) want to take this on, we can get it published to nuget pretty quickly.

I suggest we would make a new repo/package Polly.Caching.Serialization.System.Json (can set this up soon as needed)

@reisenberger
Copy link
Member

(noting on the issue that somebody has now grabbed this up-for-grabs ... in progress

@reisenberger
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants