Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate sync demos from 01 to 03 #40

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Migrate sync demos from 01 to 03 #40

merged 4 commits into from
Sep 28, 2023

Conversation

peter-csala
Copy link
Contributor

Description:

  • Renamed Demo00_NoPolicy to Demo00_NoStrategy
  • Migrated form Demo01 to Demo03 under Sync folder to use HttpClient instead of WebClient
  • Migrated policies to strategies

@peter-csala
Copy link
Contributor Author

@martincostello What do you think would it make sense to mention the migration process on the readme.md?

@martincostello
Copy link
Member

Yeah a temporary banner saying it's a work-in-progress is probably a good idea.

@peter-csala
Copy link
Contributor Author

Yeah a temporary banner saying it's a work-in-progress is probably a good idea.

Let me amend the current PR with that.

martincostello
martincostello reviewed Sep 28, 2023
View reviewed changes
PollyDemos/Sync/Demo01_RetryNTimes.cs Outdated Show resolved Hide resolved
PollyDemos/Sync/Demo01_RetryNTimes.cs Outdated Show resolved Hide resolved
PollyDemos/Sync/Demo01_RetryNTimes.cs Outdated Show resolved Hide resolved
PollyDemos/Sync/Demo01_RetryNTimes.cs Outdated Show resolved Hide resolved
PollyDemos/Sync/Demo02_WaitAndRetryNTimes.cs Outdated Show resolved Hide resolved
PollyDemos/Sync/Demo03_WaitAndRetryNTimes_WithEnoughRetries.cs Outdated Show resolved Hide resolved
PollyDemos/Sync/Demo03_WaitAndRetryNTimes_WithEnoughRetries.cs Outdated Show resolved Hide resolved
PollyDemos/Sync/Demo03_WaitAndRetryNTimes_WithEnoughRetries.cs Outdated Show resolved Hide resolved
PollyDemos/Sync/Demo03_WaitAndRetryNTimes_WithEnoughRetries.cs Outdated Show resolved Hide resolved
martincostello
martincostello reviewed Sep 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@martincostello martincostello merged commit c7cc0e8 into App-vNext:master Sep 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-csala @martincostello