fix: include URI in provider.network_choice
#2449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Dec 24, 2024
| @@ -72,14 +71,6 @@ def test_uri(geth_provider): | |||
| assert geth_provider.uri == GETH_URI | |||
|
|
|||
|
|
|||
| @geth_process_test | |||
| def test_uri_localhost_not_running_uses_random_default(config): | |||
There was a problem hiding this comment.
this now happens at the provider-connection level, so the config value is None when not actually configured (and doesn't get set to random RPC). So the behavior is the same, just happens at a different spot, it helps us know when a value was specifically configured by the user (and not injected here)
antazoey
force-pushed
the
feat/network-choice-when-configured-uri
branch
from
2305bda to
a78af4b
Compare
bitwise-constructs
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: ApeWorX/silverback#179
How I did it
When a URI is configured or passed in for a connection, use that in
provider.network_choiceHow to verify it
silverback uses the configured URI everywhere now.
I made sure:
Checklist