From 4949e04a3adeca55335d55da6b60782a0e3f95a9 Mon Sep 17 00:00:00 2001
From: Robin Candau <robincandau@protonmail.com>
Date: Sat, 20 Jul 2024 14:00:41 +0200
Subject: [PATCH] chore: update the news var value in case of error

Since https://github.com/Antiz96/arch-update/commit/384b6bcac90cb82bf7082f9ae1e2691fbf0b4e43, not only timeout are checked but also HTTP error responses.
This commit updates the value of the news var to a more generic name in case of error.
---
 src/script/arch-update.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/script/arch-update.sh b/src/script/arch-update.sh
index b7b5c9f..fda93be 100755
--- a/src/script/arch-update.sh
+++ b/src/script/arch-update.sh
@@ -355,9 +355,9 @@ list_packages() {
 # Definition of the list_news function: Display the latest Arch news and offers to read them
 list_news() {
 	info_msg "$(eval_gettext "Looking for recent Arch News...")"
-	news=$(curl -m 30 -Lfs https://www.archlinux.org/news || echo "timeout")
+	news=$(curl -m 30 -Lfs https://www.archlinux.org/news || echo "error")
 
-	if [ "${news}" == "timeout" ]; then
+	if [ "${news}" == "error" ]; then
 		echo
 		warning_msg "$(eval_gettext "Unable to retrieve recent Arch News (HTTP error response or request timeout)\nPlease, look for any recent news at https://archlinux.org before updating your system")"
 	else
@@ -418,9 +418,9 @@ list_news() {
 					news_selected=$(sed -n "${num}"p <<< "${news_titles}")
 					news_path=$(echo "${news_selected}" | sed s/\ -//g | sed s/\ /-/g | sed s/[.]//g | sed s/=//g | sed s/\>//g | sed s/\<//g | sed s/\`//g | sed s/://g | sed s/+//g | sed s/[[]//g | sed s/]//g | sed s/,//g | sed s/\(//g | sed s/\)//g | sed s/[/]//g | sed s/@//g | sed s/\'//g | sed s/--/-/g | awk '{print tolower($0)}')
 					news_url="https://www.archlinux.org/news/${news_path}"
-					news_content=$(curl -m 30 -Lfs "${news_url}" || echo "timeout")
+					news_content=$(curl -m 30 -Lfs "${news_url}" || echo "error")
 
-					if [ "${news_content}" == "timeout" ]; then
+					if [ "${news_content}" == "error" ]; then
 						echo
 						warning_msg "$(eval_gettext "Unable to retrieve the selected Arch News (HTTP error response or request timeout)\nPlease, read the selected Arch News at \${news_url} before updating your system")"
 					else