Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Auto Profile ignores different controllers #58

Closed
Rast1234 opened this issue Sep 25, 2016 · 10 comments
Closed

Auto Profile ignores different controllers #58

Rast1234 opened this issue Sep 25, 2016 · 10 comments
Assignees
Labels
Milestone

Comments

@Rast1234
Copy link

Hello. I am using SCP Toolkit to connect two PS3 controllers (Dualshock3). Antimicro works fine with them, i am able to set up different profiles for controllers in GUI. But i can't set up Auto Profile to load different profiles when a game starts. Look at screenshots:
(1) - Antimicro detects two connected controllers, i am able to set them up independently. In Auto Profile dialog i have drop-down with two controllers, with same names though. I created two profiles with two different controllers selected.
(2) - "Devices" box shows only one controller?!
(3) - Created profiles have same GUIDs in the table?!

I suppose this behavior is caused by hacks or bugs that belong to SCP toolkit, but i think it's possible to fix in Antimicro because it actually works via GUI. Maybe Auto Profile's way of enumerating controllers is different from main window's?
antimicro-dualshocks

@jsbackus
Copy link
Member

Hi @Rast1234,

Yes, looks like a bug/deficiency in AM. The Auto Profile dialog should distinguish between multiple controllers with the same name, as it does in the main dialog. I'll look into it. Thanks for the report!

@Rast1234
Copy link
Author

I also noticed that whichever controller was selected when creating Auto Profile entry, when i close and open entry properties again, the last "XInput Controller" is always selected.

@jsbackus
Copy link
Member

jsbackus commented Oct 9, 2016

Hi @Rast1234, sorry for taking so long to respond. Hmmm.. Thanks for the additional info. I'll look into it when I get a chance.

@jsbackus jsbackus modified the milestones: 2.23, 2.24 Oct 29, 2016
@vimr
Copy link

vimr commented Dec 4, 2016

Hi,
I noticed the same issue when using two wireless xbox 360 controllers (connected to the pc via one receiver. ) I'm new to antimicro and i like the tool, but unfortunately i can not use it for now ...

@jsbackus
Copy link
Member

jsbackus commented Dec 4, 2016

Hi @vimr, thanks for giving us a try! I hope to get to this soon. I need to resolve a crashing bug first. Thanks!

@vimr
Copy link

vimr commented Dec 4, 2016

@jsbackus thanks.

@jsbackus
Copy link
Member

(excuse me while I make some notes / talk to myself.. 😄 )

Tab name is a combination of joystick->getSDLName() and joystick->getName() (see makeJoystickTabs() mainwindow.cpp), and joystick->getName() is "Joystick" or "Game Controller" and the result of getRealJoyNumber(), which ultimately comes from InputDevice.

The device combo box in the auto profile dialog appears to be comprised of just getSDLName() (see the dialog constructor around line 110 or so).

Best solution is probably to allow user to specify a specific instance or all instances of a controller. Further confusing the issue is that all XInput devices appear to be named XInput. 😒 I've added issue #92 to try to address the naming issue.

@jsbackus
Copy link
Member

Need to revamp how profiles are auto-loaded. Current method assumes same profile for each controller, so need to change the signal/slot to take device index. Current method is also potentially called multiple times: once for the best match based on program, once for the default for the controller, and once for the "all default". Should change original match algorithm to only emit once...
Reference:

  • MainWindow::autoprofileLoad()
  • AutoProfileWatcher::runAppCheck()

Also need to update AutoProfileWatcher::syncProfileAssignments() to take in joystick instance matches.

@trymeouteh
Copy link

Please add an option to allow auto profiles to load a profile for all controllers of the same name or certain controllers of the same name (For example: only load a auto profile for player 1 controller and not player 2, 3, or 4)

@pktiuk
Copy link
Contributor

pktiuk commented Dec 3, 2022

AntiMicro is no longer maintained. There were no bigger fixes since 2017.
There is a new recommended version of this app called AntiMicroX.

As a part of cleanup, this issue will be closed and repository will be archived.
If you find this issue relevant also for that new version of application you can create a new issue there (but firstly check it, because many issues of the old app are fixed and there are some new functionalities implemented)
If you will decide to create a new issue for AntiMicroX remember to mention this issue for reference.

@pktiuk pktiuk closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants