Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Controllers being listed twice #22

Closed
jsbackus opened this issue Jun 26, 2016 · 14 comments
Closed

Controllers being listed twice #22

jsbackus opened this issue Jun 26, 2016 · 14 comments
Assignees
Labels
Milestone

Comments

@jsbackus
Copy link
Member

Happening at least on Windows version. Suspect it is related to SDL 2.0.4 and fix for issue #4. First step is to back the change out and rebuild with SDL 2.0.3 and retest.

@jsbackus jsbackus modified the milestone: 2.22 Jun 26, 2016
@jsbackus jsbackus added the bug label Jun 26, 2016
@jsbackus jsbackus self-assigned this Jun 26, 2016
@jsbackus
Copy link
Member Author

jsbackus commented Jul 2, 2016

Hi @WAZAAAAA0, would you please try the installer found here? It reverts back to SDL 2.0.3, which will hopefully fix the double-controllers issue. Also, please check that I correctly made the translation changes you requested. Thanks!

@jsbackus
Copy link
Member Author

jsbackus commented Jul 4, 2016

According to @mrtnkl, reverting to SDL 2.0.3 doesn't fix the 2x controller issue, at least under win10...

@mrtnkl, would you please try the following:

  • With the f56788f version, do any of the tabs work? i.e. do any of the tabs respond to button presses on the controller(s)?
  • Please install version 7f4be52a2.
    • Do you see multiple tabs per controller?
    • Do any of these tabs work? i.e. do any of these tabs respond to button presses on the controller(s)?

Thanks!

@WAZAAAAA0
Copy link

Let's see...

f56788f:

  1. both the Spanish and Italian translations (which are post-Ryochan7-demise) still have the copyright problem: "Copyright: 2013 - 2016 {2013 ?}"
  2. the version still says 2.21 but you addressed this in a previous message saying it will be updated everywhere
  3. double controller detection still happens
  4. About the languages list: the word "Spanish" should be displayed as "Español" with the Spanish setting, "Spagnolo" in Italian etc. Or we could come up with a better standard which will NOT require any manual translation effort for the future... let's type each language in their native languages only, Wikipedia style: https://i.imgur.com/pwmTTZm.png

7f4be52:
all of the above except 4
My guess it that the unreleased (thus untested) commits resurrected by DarkStarSword cause the double detection, unfortunately.

On a side note, the README.md:
The readme file displays correctly with any reader... except for GitHub. You probably need to do some EOL conversion on the last lines or something, because this is how GitHub displays them on Firefox and Chrome: https://i.imgur.com/WEKgRIf.png

@mrtnkl
Copy link

mrtnkl commented Jul 6, 2016

Hi, with the original build you sent me, I get 4 tabs (and only 1 controller detected by Windows):
4tabs

Only tab 3 actually allows controller mapping, tab 1 and 2 don't detect any presses or axis.
tab3works

I'll now go and install 7f4be52.
brb

@mrtnkl
Copy link

mrtnkl commented Jul 6, 2016

Okay, this is odd. When I started 7f4be52 it got 4 controllers as well. But now, it ... works.

I rebooted the device, started antimicro first - it said "no controllers", then I enabled the controller. It got detected by Windows and immediately by AntiMicro and only showed 1 tab! This is 7f4be52.

I mapped the keys, loaded up my Oblivion mapping and everything works. 100%.

Odd that I can't reproduce the 4 tabs bug at the moment.

@jsbackus
Copy link
Member Author

jsbackus commented Jul 9, 2016

@WAZAAAAA0 Thanks for testing! Yes, I think you're right, the change is likely on our end and not with the SDL. I can't seem to find any bug reports relating to this with the SDL project. Does anyone know of a version that definitely worked? The more recent the better. If it is on our end, then there is hope that I can get it to show up on my end and try to track it down. Just to clarify, what version of Windows are you running? 7?

Re: copyright date - thanks! I've updated issue #12 with a comment to make sure I track that down before release.

Re: names of languages - very good point! I like your second idea, using the native name for each language. I've added issue #27. Just to clarify, AntiMicro defaults to English? Ideally, AntiMicro should default to whatever the system is set for, but I don't know how tricky that is. I'll look into it.

Re: the README - Good catch! Yes, I needed to add some white space after each item. Thanks for the detail work!

@mrtnkl Interesting! So 7f4be52 is working for you on Windows 10? Good to know. That is the mainline, so there is hope we'll be able to release a version that works on Windows 10 without much work. 😃 Please keep us posted if it shows up again. The fact that it is working now but wasn't earlier is further evidence that the problem is on our end. Thanks for testing!

@WAZAAAAA0
Copy link

WAZAAAAA0 commented Jul 9, 2016

@jsbackus
The most recent and "most working" version of AntiMicro, at least on Windows, is 2.21 with SDL2.dll being downgraded from 2.0.4 to 2.0.3 ( maybe instead of downgrading, applying this commit would work too 5447bfe ), which is the one offered in the releases section. I'm running Windows 7 Ultimate 64-bit SP1.

Upon further testing, the double detection tab only occurs if the controller is ALREADY connected before launching AntiMicro. If I open AntiMicro first AND THEN physically plug in my controller into the USB port, only 1 tab is shown. mrtnkl basically said the same thing:

I rebooted the device, started antimicro first - it said "no controllers", then I enabled the controller. It got detected by Windows and immediately by AntiMicro and only showed 1 tab!

It still needs to be fixed though.

AntiMicro already defaults to whatever the system is set for (in my case, it defaulted to Italian).

@jsbackus
Copy link
Member Author

@WAZAAAAA0 Thanks! I've been able to replicate the issue in Wine (excusing this issue: #28), so I should be able to track it down.

Upon further testing, the double detection tab only occurs if the controller is ALREADY connected before launching AntiMicro. If I open AntiMicro first AND THEN physically plug in my controller into the USB port, only 1 tab is shown.

Good catch! That aught to help narrow down where the issue is. Plus, it gives us a temporary workaround. Agreed, definitely needs to be fixed.

Glad the language defaults to the current system language.

@jsbackus
Copy link
Member Author

Looks like the issue was introduced in commit fd34684. It appears that @Ryochan7 was attempting to clean up the code responsible for adding joysticks. Luckily, he has good version control habits and the commit is very succinct. Shouldn't be too difficult to debug. 😌

@andres-asm
Copy link

I know this is totally unrelated but I notice the same issue (duplicate inputs and duplicate controllers listed for my XBOX elite controller on Steam BP)

I noticed they upgraded SDL2 to 2.0.4 too...

@jsbackus
Copy link
Member Author

Hey folks, sorry it has taken so long to get back to this. I have a couple of test cases if you would be so kind as to try them for me:

At least one of these should work. Hopefully both will. Thanks!

@jsbackus
Copy link
Member Author

@fr500 Interesting! Hope we don't have two problems to track down... Thanks for letting us know!

@WAZAAAAA0
Copy link

WAZAAAAA0 commented Jul 25, 2016

Both 93099d0 and cf500290 have solved the double controller listing on Windows 7 Ultimate 64-bit SP1.

@jsbackus
Copy link
Member Author

Great! Thanks for testing! I'll try to take care of the few small loose ends we have and we'll try to release next weekend. Thanks again!

jsbackus added a commit that referenced this issue Jul 26, 2016
…h code from commit #fd34684 in and out. Looks like the code in addInputDevice is causing a problem...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants