Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Fix incorrect threshold calculation in setFinalizers #668

Closed
wants to merge 1 commit into from
Closed

[1.0] Fix incorrect threshold calculation in setFinalizers #668

wants to merge 1 commit into from

Conversation

linh2931
Copy link
Member

Fixes an issue that the TestHarness's setFinalizers did not use the same threshold formula as the core contract.

@linh2931 linh2931 requested review from heifner, arhag and greg7mdp August 29, 2024 04:01
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Fix threshold calculation in test using bios set finalizers.
Note:end

@linh2931
Copy link
Member Author

Managed to get #662 in. The changes in this PR was a part of #662. No longer needed.

@linh2931 linh2931 closed this Aug 29, 2024
@spoonincode spoonincode mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

@arhag arhag Awaiting requested review from arhag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linh2931 @ericpassmore @greg7mdp @heifner