-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] Logging improvements #665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Also indicate why producer is implicitly paused.
linh2931
reviewed
Aug 28, 2024
bool is_implicitly_paused() const { | ||
enum class implicit_pause { | ||
not_paused, // not implicitly paused | ||
prod_paused, // paused do to not receiving vote associated with producer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do
-> due
greg7mdp
reviewed
Aug 28, 2024
linh2931
approved these changes
Aug 28, 2024
greg7mdp
approved these changes
Aug 28, 2024
arhag
reviewed
Aug 28, 2024
greg7mdp
reviewed
Aug 28, 2024
…ty check when liveness succeeds as it is not checked. Use debug level for all but the summary log in decide_vote. Add additional info to info level decide_vote summary log.
greg7mdp
requested changes
Aug 29, 2024
arhag
approved these changes
Aug 29, 2024
greg7mdp
approved these changes
Aug 29, 2024
arhag
approved these changes
Aug 29, 2024
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc logging improvements:
Change
liveness check failed
log message todebug
level to match logging of other finality checks indecide_vote
.Add block timestamp to all
Not producing because
log messages inproducer_plugin
.Indicate why producer is implicitly paused in the
Not producing because
log message.Add
info
level decide_vote summary log statement, for example:safety.dat
file. Now when invalid bls key you get the following:extraNodeosArgs
tocluster.launch
. missed in [1.0] Test: Fix liveness_test.py integration test flakiness #661.