-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0]Add integration tests for production-pause-vote-timeout #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-provided finalizer names
…y masking test failures
…tion_pause_vote_timeout_test_shape.json
…on-pause-vote-timeout-ms 0
…lizerNode to finalizercNode
heifner
requested changes
Aug 28, 2024
greg7mdp
reviewed
Aug 28, 2024
…nstead of using waitForHeadToAdvance which can be wrong)
heifner
approved these changes
Aug 29, 2024
arhag
requested changes
Aug 29, 2024
arhag
approved these changes
Aug 29, 2024
Note:start |
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup:
Use five nodes in an hourglass topology. The center node is a relay node that initially has vote-threads enabled. The other 4 peripheral nodes are:
Test cases:
The PR also fixes an issue that the TestHarness's
setFinalizers
did not use the same threshold formula as the core contract.Resolves #542