Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P: Do not burden the main thread with the connection monitor #817

Closed
heifner opened this issue Sep 24, 2024 · 0 comments · Fixed by #937
Closed

P2P: Do not burden the main thread with the connection monitor #817

heifner opened this issue Sep 24, 2024 · 0 comments · Fixed by #937
Assignees
Labels
enhancement New feature or request OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Sep 24, 2024

Currently net_plugin launches the connection monitor and keep alive timer on the main thread:

my->ticker();
my->start_monitors();

These can and should be started on the net_plugin thread pool.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Sep 24, 2024
@arhag arhag added enhancement New feature or request and removed triage labels Sep 30, 2024
@heifner heifner self-assigned this Oct 15, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Oct 15, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Oct 15, 2024
@heifner heifner added this to the Spring v1.1.0-rc1 milestone Oct 15, 2024
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Oct 15, 2024
heifner added a commit that referenced this issue Oct 17, 2024
heifner added a commit that referenced this issue Oct 21, 2024
P2P: Use net threads for connecting and timers
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OCI Work exclusive to OCI team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants