Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max-reversible-blocks syncing old blocks #579

Closed
heifner opened this issue Aug 19, 2024 · 1 comment · Fixed by #587 or #589
Closed

max-reversible-blocks syncing old blocks #579

heifner opened this issue Aug 19, 2024 · 1 comment · Fixed by #587 or #589
Assignees
@heifner
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.0-rc2

Comments

@heifner
Copy link
Member

heifner commented Aug 19, 2024

Matthew Darwin

Trying to sync kylin from genesis fails with Exceeded max reversible blocks allowed, fork db size 3634 >= max-reversible-blocks 3600. There is a period at the start of the chain where LIB fails to move forward.

Should max-reversible-blocks be applied on p2p sync ancient blocks?

LIB drifts by at least 65K blocks.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 19, 2024
@heifner
Copy link
Member Author

heifner commented Aug 19, 2024

Make max-reversible-blocks only apply to savanna blocks.

@bhazzard bhazzard added 👍 lgtm bug The product is not working as was intended. and removed triage labels Aug 19, 2024
@heifner heifner self-assigned this Aug 19, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Aug 19, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 19, 2024
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
GH-579 Update max-reversible-blocks to work with savanna blocks
1d200e1
@heifner heifner mentioned this issue Aug 19, 2024
Merged
@heifner heifner linked a pull request Aug 19, 2024 that will close this issue
[1.0] Update max-reversible-blocks to only enforce savanna blocks #587
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Aug 19, 2024
@arhag arhag added this to the Spring v1.0.0-rc2 milestone Aug 19, 2024
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
Merge pull request #587 from AntelopeIO/GH-579-max-reversible-blocks-…
381726b 
…savanna

[1.0] Update max-reversible-blocks to only enforce savanna blocks
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-579-max-rev…
2e83a77 
…ersible-blocks-savanna-main
@heifner heifner mentioned this issue Aug 19, 2024
Merged
@heifner heifner linked a pull request Aug 19, 2024 that will close this issue
[1.0 -> main] Update max-reversible-blocks to only enforce savanna blocks #589
Merged
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
Merge pull request #589 from AntelopeIO/GH-579-max-reversible-blocks-…
9dffba4 
…savanna-main

[1.0 -> main] Update max-reversible-blocks to only enforce savanna blocks
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Spring v1.0.0-rc2
4 participants
@bhazzard @heifner @arhag @enf-ci-bot