Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test proposer policy does not become active when finality has stalled #553

Closed
arhag opened this issue Aug 15, 2024 · 2 comments · Fixed by #607 or #616
Closed

Test proposer policy does not become active when finality has stalled #553

arhag opened this issue Aug 15, 2024 · 2 comments · Fixed by #607 or #616
Assignees

Comments

@arhag
Copy link
Member

arhag commented Aug 15, 2024

Add an additional libtester test (though using the Savanna cluster testing utility) to test new behavior of #454.

Create a test where we partition the network (two nodes on one side and two nodes on the other side). Propose a new proposer policy in this scenario and notice that it does not become active. Then reconnect the network and finality should start advancing again and the proposer policy should automatically be promoted to become active.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 15, 2024
@arhag arhag added 👍 lgtm and removed triage labels Aug 15, 2024
@arhag arhag added this to the Spring v1.0.0 milestone Aug 15, 2024
@arhag arhag added this to the Spring v1.0.0 milestone Aug 15, 2024
@arhag
Copy link
Member Author

arhag commented Aug 19, 2024

#582 also resolves this issue.

@greg7mdp
Copy link
Contributor

Actually I misread the issue, #582 does not resolve it, will implement the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment