Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log BLS public keys and producer public keys on startup/shutdown #461

Closed
heifner opened this issue Aug 1, 2024 · 0 comments · Fixed by #505
Closed

Log BLS public keys and producer public keys on startup/shutdown #461

heifner opened this issue Aug 1, 2024 · 0 comments · Fixed by #505
Assignees
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Aug 1, 2024

Currently signature-provider in Non-default options log are completely masked out:

info  2024-08-01T18:03:24.494 nodeos.be main.cpp:62                   log_non_default_opti ] Non-default options: data-dir = spring-testnet4-data2, config-dir = spring-testnet4, plugin = eosio::chain_api_plugin, genesis-json = spring-testnet4/genesis.json, chain-state-db-size-mb = 32000, database-map-mode = mapped_private, http-server-address = 127.0.0.1:8899, p2p-listen-endpoint = 0.0.0.0:9899:0, signature-provider = ***, signature-provider = ***, producer-name = zombiezombie, p2p-peer-address = p2p.spring-beta4.jungletestnet.io:9898

Would be handy to log the public key portion. Something like:

signature-provider = PUB_BLS_MEiD85FQ_7-WMBno5xit7-kHcCaJak7UVtcFQayDfneJCQT1mleNd-FQ9kBRHL4A_kHg41rEjhHXlfiH0GWqB2PP6mRUBR_wiFwOsO8lKUtDa_mBjtGSUVIo2sQWKDMGjEGASA=KEY:***
signature-provider = EOS7GQpG7KWgw7FaFDnkua1LadP71nF1kVqAXZ5uD8apE3gUoCxX4=KEY:***
@arhag arhag added enhancement New feature or request 👍 lgtm and removed triage labels Aug 6, 2024
@arhag arhag modified the milestones: Savanna: Cusp, Spring v1.0.0 Aug 6, 2024
@heifner heifner self-assigned this Aug 8, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Aug 8, 2024
heifner added a commit that referenced this issue Aug 8, 2024
Mask out only the private key when logging signature-provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants