Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pending policy generation number to finality digest #409

Closed
arhag opened this issue Jul 25, 2024 · 0 comments · Fixed by #410
Closed

Add pending policy generation number to finality digest #409

arhag opened this issue Jul 25, 2024 · 0 comments · Fixed by #410
Assignees
@linh2931
Labels
consensus-protocol Change to the consensus protocol. Impacts light client validation. 👍 lgtm
Milestone
Savanna: Producti...

Comments

@arhag
Copy link
Member

arhag commented Jul 25, 2024 •
edited
Loading

Add last_pending_finalizer_policy_generation to finality_digest_data_v1 (which is used in the finality digest calculation). If a pending policy is currently present, then this field will hold the generation number of that pending policy. Otherwise, the field will hold the same number as active_finalizer_policy_generation.

last_pending_finalizer_policy_generation should also be added into finality_data_t which is sent via SHiP.
@arhag arhag added consensus-protocol Change to the consensus protocol. Impacts light client validation. 👍 lgtm labels Jul 25, 2024
@arhag arhag added this to the Savanna: Production-Ready milestone Jul 25, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jul 25, 2024
@arhag arhag removed the triage label Jul 25, 2024
@linh2931 linh2931 self-assigned this Jul 25, 2024
@linh2931 linh2931 mentioned this issue Jul 25, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
consensus-protocol Change to the consensus protocol. Impacts light client validation. 👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Savanna: Production-Ready
Development

Successfully merging a pull request may close this issue.

Add pending policy generation number to finality digest AntelopeIO/spring
3 participants
@arhag @linh2931 @enf-ci-bot