Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit apply blocks time in controller #284

Closed
heifner opened this issue Jun 13, 2024 · 1 comment · Fixed by #921, #922 or #926
Closed

Limit apply blocks time in controller #284

heifner opened this issue Jun 13, 2024 · 1 comment · Fixed by #921, #922 or #926
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.3

Comments

@heifner
Copy link
Member

heifner commented Jun 13, 2024 •
edited by arhag
Loading

Currently the controller in maybe_switch_forks can apply a large set of blocks while syncing in the non-switch_fork case. It would be useful to time bound this loop so that get_info or other high priority tasks have an opportunity to run.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jun 13, 2024
@arhag arhag added 👍 lgtm and removed triage labels Aug 12, 2024
@arhag arhag added this to the Spring v1.0.0 milestone Aug 12, 2024
@heifner heifner mentioned this issue Aug 13, 2024
Closed
This was referenced Sep 27, 2024
Closed
Open
Closed
@heifner heifner self-assigned this Oct 9, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Oct 9, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Oct 9, 2024
@heifner heifner removed their assignment Oct 9, 2024
@heifner heifner removed the OCI Work exclusive to OCI team label Oct 9, 2024
@heifner
Copy link
Member Author

heifner commented Oct 9, 2024

Not sure this is needed if #876 is worked.

@arhag arhag moved this from In Progress to Todo in Team Backlog Oct 9, 2024
@heifner heifner self-assigned this Oct 9, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Oct 9, 2024
heifner added a commit that referenced this issue Oct 9, 2024
@heifner
GH-284 Break out of maybe_switch_forks tight apply blocks loop every …
8572b97 
…~500ms.
heifner added a commit that referenced this issue Oct 9, 2024
@heifner
GH-284 Set replaying flag during "replay" of forkdb. Also add in 1000…
514b479 
… block logging during replay and startup of processing of the forkdb.
heifner added a commit that referenced this issue Oct 9, 2024
@heifner
GH-284 milliseconds instead of microseconds
0434e15
@heifner heifner mentioned this issue Oct 10, 2024
Merged
@heifner heifner linked a pull request Oct 10, 2024 that will close this issue
[1.0.3] Limit apply blocks #921
Merged
heifner added a commit that referenced this issue Oct 10, 2024
@heifner
GH-284 Use scoped_set_value for replaying.
5f6273a
heifner added a commit that referenced this issue Oct 10, 2024
@heifner
GH-284 Always complete a switch_fork
6c36b95
heifner added a commit that referenced this issue Oct 10, 2024
@heifner
GH-284 Use scoped_set_value for replaying
346e84e
heifner added a commit that referenced this issue Oct 10, 2024
@heifner
GH-284 Add timelimit to apply_blocks and return if complete or incomp…
dd5a078 
…lete
heifner added a commit that referenced this issue Oct 10, 2024
@heifner
GH-284 Use recursive lambda to repost if not complete.
eae3367
@heifner heifner mentioned this issue Oct 10, 2024
Merged
@heifner heifner moved this from Todo to In Progress in Team Backlog Oct 10, 2024
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Oct 10, 2024
heifner added a commit that referenced this issue Oct 11, 2024
@heifner
Merge branch 'main' into GH-284-partial-apply-blocks
ae2c786
heifner added a commit that referenced this issue Oct 11, 2024
@heifner
Merge pull request #922 from AntelopeIO/GH-284-partial-apply-blocks
5760d26 
Limit apply blocks
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Oct 11, 2024
heifner added a commit that referenced this issue Oct 11, 2024
@heifner
Merge pull request #921 from AntelopeIO/GH-284-limit-apply-blocks
87079b3 
[1.0.3] Limit apply blocks
heifner added a commit that referenced this issue Oct 11, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-284-limit-a…
8e29972 
…pply-blocks-main
@heifner heifner mentioned this issue Oct 11, 2024
Merged
heifner added a commit that referenced this issue Oct 11, 2024
@heifner
Merge pull request #926 from AntelopeIO/GH-284-limit-apply-blocks-main
227121f 
[1.0.3 -> main] Limit apply blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
Spring v1.0.3
3 participants
@heifner @arhag @enf-ci-bot