Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtester voting optimizations #264

Closed
arhag opened this issue Jun 10, 2024 · 0 comments · Fixed by #279
Closed

libtester voting optimizations #264

arhag opened this issue Jun 10, 2024 · 0 comments · Fixed by #279
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Savanna: Cusp

Comments

@arhag
Copy link
Member

arhag commented Jun 10, 2024

By default only use 1 finalizer key.

Additionally, consider the following optimization for calls to produce_blocks:

  • If the number of blocks to produce is 3 or less, continue voting on each block as is currently done.
  • If the number of blocks to produce is more than 3, only vote on the last 3 blocks.

This saves time on unnecessary BLS math operations for tests that need to produce a lot of empty blocks as part of the test.
@arhag arhag added this to the Savanna: Cusp milestone Jun 10, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jun 10, 2024
@arhag arhag added 👍 lgtm and removed triage labels Jun 10, 2024
@linh2931 linh2931 mentioned this issue Jun 10, 2024
Merged
@heifner heifner self-assigned this Jun 11, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Jun 11, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Jun 11, 2024
heifner added a commit that referenced this issue Jun 11, 2024
@heifner
GH-264 Remove production of unneeded blocks in tests to speed up test…
ef6d68d 
… runs
@heifner heifner mentioned this issue Jun 11, 2024
Merged
heifner added a commit that referenced this issue Jun 11, 2024
@heifner
Merge pull request #273 from AntelopeIO/GH-264-unneeded-blocks
99e4f89 
Test: Remove production of unneeded blocks
heifner added a commit that referenced this issue Jun 12, 2024
@heifner
GH-264 Revert cherry-pick changes
c9ac817
heifner added a commit that referenced this issue Jun 12, 2024
@heifner
GH-264 Remove unused num_blocks_to_producer_before_shutdown
ced0a98
heifner added a commit that referenced this issue Jun 12, 2024
@heifner
GH-264 Only vote on the last 3 blocks of a set of empty blocks to avo…
95828d2 
…id excessive voting slowing down tests
heifner added a commit that referenced this issue Jun 12, 2024
@heifner
GH-264 Update tests to use empty blocks without votes to improve perf…
9a8e4b8 
…ormance of tests
@heifner heifner mentioned this issue Jun 12, 2024
Merged
heifner added a commit that referenced this issue Jun 13, 2024
@heifner
GH-264 When producing multiple blocks only vote on the last 4 to move…
2ad6fb7 
… finality
heifner added a commit that referenced this issue Jun 13, 2024
@heifner
Merge branch 'main' into GH-264-test-voting
3e2648e
heifner added a commit that referenced this issue Jun 13, 2024
@heifner
GH-264 simplify
df82aa3
heifner added a commit that referenced this issue Jun 13, 2024
@heifner
Merge pull request #279 from AntelopeIO/GH-264-test-voting
391be54 
Test: Optimize test by minimizing voting
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Savanna: Cusp
Development

Successfully merging a pull request may close this issue.

Test: Optimize test by minimizing voting AntelopeIO/spring
3 participants
@heifner @arhag @enf-ci-bot